search

aakarshg / sincgars

Configure OpenShift cluster to add remotewrite for long term storage of cluster metrics
Apache License 2.0
0 stars 0 forks source link

[BUG] running sincgars replaces current config in the configmap #3

Open aakarshg opened 4 years ago

aakarshg commented 4 years ago

If the configmap has some config, the patching done by sincgars seems to have deleted existing config.

aakarshg commented 4 years ago

Looking at https://kubernetes.io/docs/tasks/run-application/update-api-object-kubectl-patch/#notes-on-the-strategic-merge-patch looks like a simple merge probably doesn't exist, we'll have to look at the json merge by reading existing configmap and updating the list in place.

bengland2 commented 4 years ago

So do you mean that we should have done a more selective edit to enable sincgars? A workaround appears to be:

oc -n openshift-monitoring delete configmap cluster-monitoring-config

and then re-run deploy.py. It appears that deploy py behaves differently if the configmap doesn't already exist. I was able to change sincgars parameters in this way.