search

aalavandhaann / blueprint-js

The Javascript es6 version of the original furnishup/blueprint3d. Need some royalty free low poly models for the inventory. Can someone help me with this?
MIT License
504 stars 158 forks source link

Can't add some objects in 3D #19

Closed GWillmann closed 5 years ago

GWillmann commented 5 years ago

Describe the bug When clicking on some 3D objects to add them to the scene, a error occurs and the object isn't added to the scene.

To Reproduce Create a new layout

  1. Go to 3D
  2. Click on Toilet
  3. Open developer console
  4. See error : TypeError: "cached is undefined"

Expected behavior Object is added to the scene

Screenshots

Screenshot 2019-03-16 at 14 16 18

Desktop (please complete the following information):

Fix Simply adding typeof cached !== 'undefined fixes the problem and makes it possible to add the object to the scene. However being relatively new to this project, I don't know in which library it uses I should submit a PR. There are many occurrences of the faulty line:

Screenshot 2019-03-16 at 14 11 40

Thanks for your work!

aalavandhaann commented 5 years ago

Many thanks for pointing this out GWilliam. I believe this error stems from the GLTFLoader module. Have a nice day ahead.

Regards,

0K

aalavandhaann commented 5 years ago

I believe this is coming from the @calvinscofield because the GLTFLoader is imported from there. Many thanks for this find. I need to fix it soon.

Regards,

0K

aalavandhaann commented 5 years ago

This bug has been resolved with three-gltf-loader@l.105.0. Feel free to reopen this issue