Open AfanasievAM opened 4 years ago
Normally you would click on the floor in 3D plane and then add item to properly place in that room. But I am also facing this problem with these new changes.
In any case, I can't add any objects. Even if you choose floor on 3D plan.
I'm seeing the same issue using the demo in Chrome and Safari as well
I thought I'd jump into the codebase and see what I could find. It seems this line is raising an exception whenever you try to add an item.
item.js:80
let mixer = new AnimationMixer(this._loadedgltfobject.scene); <----
let clips = loaded_gltf_entity.animations;
if (clips != undefined) {
if (clips.length) {
// clips.forEach((clip) => {
// console.log(clip);
// console.log(clip.name, clip.duration);
// // mixer.clipAction(clip).play();
// });
let frame = this.metadata.frame;
let clip = AnimationClip.findByName(clips, frame);
if (clip != undefined && clip != null) {
mixer.clipAction(clip).play();
mixer.update(0.0);
}
}
}
this.add(this._loadedgltfobject.scene);
I can't quite seem to see where this._loadedgltfobject
is defined.
Also, forgive my ignorance. I know nothing about three.js or your repo but I stumbled upon it today and was so impressed I couldn't help but dive in.
Hello dawlister,
My sincere apologies for the delayed reply. Actually I am in the process of overhauling the entire framework. This is to move it closer to a much cleaner codebase. You can see the latest version now on the master. I am slowly trying to add back all the missing functionalities and it's almost there. The next step is to facilitate the adding of items. But given that the threejs has moved to Gltf instead of legacy formats I am rather finding it difficult to find free models for the demo purposes. Stay tuned and thanks for your kind words
It's good to see those changes, when they are expected to be complete. I am using version 1 and wanted to cherry pick from the version 2?
I have some question for my own understanding, I see you used the pixijs, what the benefit we got from that? and you switched to parcel for bundling?
parcel
pixijs
I am using version 1 and wanted to cherry pick from the version 2?
I am afraid it is not going to be a easy ride for this one. The major reason I overhauled the entire framework is to lose some of the implementation mechanisms that I disagree about. However, goodluck on that.
Regards,
Thank you very much for answering my question with explanation. Albeit, I do have some other question, if you'd like to answer
Hello dawlister,
My sincere apologies for the delayed reply. Actually I am in the process of overhauling the entire framework. This is to move it closer to a much cleaner codebase. You can see the latest version now on the master. I am slowly trying to add back all the missing functionalities and it's almost there. The next step is to facilitate the adding of items. But given that the threejs has moved to Gltf instead of legacy formats I am rather finding it difficult to find free models for the demo purposes. Stay tuned and thanks for your kind words
I can help you out for 3D models in any format
Can't added objects on 3D-plane in Demo version and Locale version.
Desktop:
There is also a bug on the local version.