search

aalhour / C-Sharp-Algorithms

:books: :chart_with_upwards_trend: Plug-and-play class-library project of standard Data Structures and Algorithms in C#
MIT License
5.92k stars 1.4k forks source link

Nuget #114

Closed nickntg closed 4 years ago

nickntg commented 4 years ago

This might help to get started with nuget (see #46).

Before being able to run publish_nuget.cmd you'll need to create an account in nuget.org.

aalhour commented 4 years ago

Hi @nickntg,

Thanks for the addition. Please read the Contributor's Guide before submitting Pull Requests. There should be an issue for any proposed change. Ideally, we will discuss the issue there first and then move to a pull request.

PatrykOlejniczak commented 4 years ago

Hello @nickntg

Can you split this into 2 separate pr one for nuget and other one for Primes list fix?

Greetings

nickntg commented 4 years ago

Yeah, I can do that. I did that in order to ensure that everything stays packed in the library and there is no need to add the data folder in the nuget. Still want me to do it?

PatrykOlejniczak commented 4 years ago

Yea, i meant, one pr = one change (one issue), just to make pr small/easy to review :)

aalhour commented 4 years ago

@nickntg - any updated from your side?

nickntg commented 4 years ago

@aalhour Sure, will do and submit new PRs.

aalhour commented 4 years ago

@nickntg - now that #124 is merged, please clean up this PR and make sure it only contains the changes relevant to Nuget publishing.

nickntg commented 4 years ago

@aalhour Done. However, this works on windows machines only...