aalhour / C-Sharp-Algorithms

:books: :chart_with_upwards_trend: Plug-and-play class-library project of standard Data Structures and Algorithms in C#
MIT License
5.92k stars 1.4k forks source link

Fix test/impl AVL trees #83

Closed PatrykOlejniczak closed 4 years ago

PatrykOlejniczak commented 5 years ago

Hello, same story just like with RedBlackTree issue, I noticed that not all tests pass. I would like to work on these tests or implementation depends on what the problem will turn out to be. I will try to add more test cases.

Related with an earlier reported problem https://github.com/aalhour/C-Sharp-Algorithms/issues/76

Regards.

gregfra commented 5 years ago

Patryk, I just made a PR to correct the failing subtest. You can review and/or add AVL tree subtests and I can look those over for you.

PatrykOlejniczak commented 5 years ago

Hi, for me looks good, thx for do that, but I think repo is dead or susspended (my pr for RBT is hanging a month), maybe owner say something @aalhour

aalhour commented 5 years ago

Hello @PatrykOlejniczak, @gregfra,

I'd be more than happy to review and accept contributions but after I get the unit tests fixed. If you guys can help me with that I'd appreciate it a lot! The problem is that Travis CI no longer runs the unit tests projects and I would like someone to help me fix that.

Cheers, Ahmad

PatrykOlejniczak commented 4 years ago

I'll close this issue fix #76 is already merged.

Thanks @gregfra