Closed scohe001 closed 5 years ago
Hi @scohe001,
Can you please pull the latest changes on master
branch and push them to your repo? They're supposed to run the unit tests for all algorithms on Travis CI successfully and I'd like to see that the tests for the merge sort algorithm are passing.
Cheers!
Huh, it looks like several tests are failing @aalhour, but none of them related to the code I've touched. Is this expected?
Congrats on becoming a first-time contributor, @scohe001!
Thank you! Glad I could help :)
Change Notes for
MergeSorter.cs
:collection
is 2 will already be handled properly if we let the collection be split and merged. There's no need to explicitly write a case for it.startIndex
andendIndex
are unneeded.startIndex
will always be 0 andendIndex
will always becollection.Count - 1
. It seems someone started to write an in-place index-based MergeSort, but switched to one that splits and creates new Lists.