search

aalises / age-of-empires-II-api

API for Age of Empires II Built with Flask-RESTFul + SQLAlchemy
https://age-of-empires-2-api.herokuapp.com
BSD 3-Clause "New" or "Revised" License
120 stars 31 forks source link

Update with new civilizations #14

Closed AndyTheNerd closed 3 years ago

AndyTheNerd commented 3 years ago

This is a PR that includes all new civs from the Age2 DE release. This does not reflect on other files regarding units and structures, but it's a start.

Patross commented 3 years ago

uwu

aalises commented 3 years ago

Heyya! thanks for the update and contributing! ✨ . There are some errors when parsing the civilizations .csv though so it's crashing when generating the new data... this is the error log:

Line #9 (got 8 columns instead of 7)
Line #14 (got 10 columns instead of 7)
Line #19 (got 11 columns instead of 7)
Line #30 (got 9 columns instead of 7)

👀 The columns are delimited by commas and the different items inside the same column by semicolons so there must be some typos around 😅 . After fixing that, you will have to regenerate and commit data.db (deleting it and running python app.py and making a request should generate it again), and everything should be good!

AndyTheNerd commented 3 years ago

Sounds good!

aalises commented 3 years ago

@AndyTheNerd what's the status? do you have some time to work on it? It's a good start to gaining some Hacktoberfest Karma.

AndyTheNerd commented 3 years ago

Sorry, I don't have a lot of free time these days. It should be really close, just some small spacing errors.

aalises commented 3 years ago

@AndyTheNerd updated here https://github.com/aalises/age-of-empires-II-api/pull/17 , closing this as it's a duplicate. Thanks for contributing!