search

aalises / age-of-empires-II-api

API for Age of Empires II Built with Flask-RESTFul + SQLAlchemy
https://age-of-empires-2-api.herokuapp.com
BSD 3-Clause "New" or "Revised" License
120 stars 31 forks source link

Add new dlc units to the dataset #22

Open shyam-s00 opened 3 years ago

shyam-s00 commented 3 years ago

I've added new dlc units to the dataset.

aalises commented 3 years ago

Hey @shyam-s00 , seems like it broke the tests. Could you check it? thanks!

shyam-s00 commented 3 years ago

@aalises Does the test run against the data from DB for asserting?

kprkr commented 3 years ago

Any luck with this? Hoping for a full API (with new DLC civs)

gvrettos commented 7 months ago

@aalises Does the test run against the data from DB for asserting?

@shyam-s00 Indeed, that is the case. If you check this test here you will see that the API calls the database. So, any changes to the csv files would mean that also changes in the database file are required. Finally, keep in mind that Python 3.6.x is suggested. I had a try with 3.9.x but the tests failed with the lazy='dynamic' options used in relationships between tables. In 3.6.x this is just a warning, so the tests pass.

P.S. I know I am late to the party 😄, but as a previous consumer now I take the chance to dive into this API. Many 👍 to the creator @aalises!