aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

fix-portuguese_translation #102

Closed JNMarcos closed 6 years ago

JNMarcos commented 6 years ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x ] Other... Please describe: Translation

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

aalok05 commented 6 years ago

Thanks @JNMarcos !

aalok05 commented 6 years ago

Hey @JNMarcos , there is an issue where some characters are being replaced with unicode question mark (�) character. Can you make sure that these characters appear as expected in the app?

JNMarcos commented 6 years ago

I had forgotten to save as UTF-8. Fixed.

aalok05 commented 6 years ago

Great. Merging this.