search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 34 forks source link

Add Turkish translation #104

Closed berkantkz closed 6 years ago

berkantkz commented 6 years ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[x] Other... Please describe: Translation

What is the current behavior?

It doesn't include Turkish translation.

What is the new behavior?

It does now include Turkish translation.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

No additional information required.

aalok05 commented 6 years ago

Looks good. Thanks for the contribution 👍

aalok05 commented 6 years ago

Hey @berkantkz I've changed the base branch to dev and there seems to be a conflict. Can you have a look?

berkantkz commented 6 years ago

I have a warning saying that This branch has conflicts that must be resolved Only those with write access to this repository can merge pull requests.

You may add it yourself. It's okay. You can also credit to me if you want but not necessary.

aalok05 commented 6 years ago

It seems you have replaced the English file with the Turkish file, instead of just adding the Turkish file.

berkantkz commented 6 years ago

Oh, maybe 😄 I may have forgotten to copy all the stuff and paste in a newly created language file. Sorry for mismatches.

aalok05 commented 6 years ago

No worries 😄