aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 34 forks source link

Toast Notification (can be enabled/disabled from settings) #110

Closed rafsanulhasan closed 6 years ago

rafsanulhasan commented 6 years ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[X] Other... Please describe: Installed NuGet packages

What is the current behavior?

App does not show any toast notifiction

What is the new behavior?

App will show unread GitHub user notifications to the toast if it is Enabled in the Notification Settings

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

This PR closes issue #98

aalok05 commented 6 years ago

Great work as always @rafsanulhasan 😄

rafsanulhasan commented 6 years ago

there is a bug in this one. In the toast, the issue/PR, distinguished by status, icon is so big and should be cropped/resized.

rafsanulhasan commented 6 years ago

Thanks!