Feature toast notification - Githubissues

aalok05 / CodeHub

A UWP GitHub Client

MIT License

177 stars 35 forks source link

Feature toast notification #120

Closed rafsanulhasan closed 5 years ago

rafsanulhasan commented 5 years ago

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Clicking on Toast does not
- open correct page
- mark the notification as read
Clicking on Toast Action (Mark Read) does not
- work correctly
- sync with notifications view page
Clicking on an item of notifications view does not
- open correct page
- not sync with toasts

What is the new behavior?

Clicking on Toast does
- open correct page
- mark the notification as read
Clicking on Toast Action (Mark Read) does
- work correctly
- sync with notifications view page
Clicking on an item of notifications view does
- open correct page
- sync with toasts

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information