search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 34 forks source link

Cannot login github account #132

Closed Zrincet closed 5 years ago

Zrincet commented 6 years ago

tim 20181107174109 Authorize button is disabled.

aalok05 commented 6 years ago

Hmmmm wierd.

rafsanulhasan commented 6 years ago

Hi @aalok05, I think the changed app Id and key in app config is causing the problem since you have changed it in the dev branch. While deployment to have to change it back to original one. Though in my PC, its working without any issues

aalok05 commented 6 years ago

@Zrincet Is this screenshot from the store app? Or are you running the solution locally?

kazi-10g80d commented 6 years ago

same issue

aalok05 commented 6 years ago

@KaziFarhanuddin Does this happen in the store app or your local repo?

redblue9771 commented 6 years ago

same issue + 1

windows 1809 and above

Zrincet commented 5 years ago

@aalok05 App downloaded in the Microsoft Store，and the version of windows10 is 1809.

aalok05 commented 5 years ago

Ok, working on this. @rafsanulhasan thoughts?

rafsanulhasan commented 5 years ago

@aalok05, I am facing the same issue too after revoking permission from GitHub OAuth App. It might be solved by updating the Windows UWP SDK itself from the NuGet.

codehuberror2

I found another issue related to it maybe, it is showing a warning that Internet Explorer (IE) is no longer supported. This happened because when you are calling WebAuthenticationBroker from the AuthService, it might be getting/using IE behind the scenes to show the OAuth Login window from GitHub. Updating the UWP SDK might solve the problem because the latest SDK might be using Edge instead of IE, but I'm not sure really. Try using other ways to show up the OAuth Dialog might solve the issue.

codehuberror

aalok05 commented 5 years ago

I think the two issues are related. JS is not enabled in the webview. https://stackoverflow.com/questions/44425233/why-is-the-github-authorization-button-in-the-oauth-flow-grayed-out

aalok05 commented 5 years ago

I'll update the UWP SDK and if this works, I'll submit to store ASAP. Thanks for your patience.

aalok05 commented 5 years ago

https://social.msdn.microsoft.com/Forums/en-US/ff3631c1-9264-47d7-9906-107a0614cdd7/uwp-how-to-set-webauthenticationbroker-to-use-edge-instead-of-ie?forum=wpdevelop

I'll have to implement a custom OAuth flow that uses Edge (Webview) instead of WebAuthenticationBroker, because WebAuthenticationBroker uses IE and IE is not supported by GitHub anymore. I blame MSFT for still using IE in WebAuthenticationBroker popup window, This is shitty.

rafsanulhasan commented 5 years ago

custom flow for OAuth is always the best solution for any mobile/web/desktop app. I wish GitHub would have supported OpedID Connect along with OAuth.

rafsanulhasan commented 5 years ago

@aalok05 I think instead of implicit flow you should use hybrid flow for better security

rafsanulhasan commented 5 years ago

Microsoft is making Edge a Chromium based Browser and going to bring it into UWP. I hope it's gonna work then...

duxingzhe commented 5 years ago

Please update your UWP app. I can't use it completely now. That's a terrible experience. I want to use UWP to view Github.com instead of the web. Please update it as soon as possible.

aberus commented 5 years ago

This link could help resolve this issue https://peterfoot.net/2019/03/13/webauthenticationbroker-and-github/ https://github.com/inthehand/Authful

aalok05 commented 5 years ago

@aberus Thanks, will have a look.

aalok05 commented 5 years ago

@aberus This is awesome. It’s exactly what we need.

aalok05 commented 5 years ago

Addressed in 393a30b