Trending Pivot slide gesture

aalok05 / CodeHub

A UWP GitHub Client

MIT License

177 stars 34 forks source link

Trending Pivot slide gesture #22

Closed rootasjey closed 7 years ago

rootasjey commented 7 years ago

Hello, First of all, good work for this app.

It seems that I can't slide horizontally on the trending view to change PivotItem. For example, from 'today' to 'this week'.

This issue happens when I'm on phone (Lumia 650). I'll try to look into this issue this weekend.

aalok05 commented 7 years ago

Hey! I actually thought I fixed this one by doing this <userControls:RepoListItem ManipulationMode="System" /> But turns out it is still a problem. Not sure why.

rootasjey commented 7 years ago

It seems that this property (on PullToRefreshListView) is blocking touch manipulations: IsPullToRefreshWithMouseEnabled="True"

I don't know which action you'd like to take:

Deactivate this option
Deactivate this option only on mobile devices
Try to manually handle touch manipulations on PullToRefreshListView

I wonder if this is the correct PullToRefreshListView's behavior or a bug.

aalok05 commented 7 years ago

Thanks for the analysis. I'll try the second option (Deactivate this option only on mobile devices), could you also try it and test it on a mobile device? (I do my testing on an emulator). It does not seem like the ideal behaviour though.

rootasjey commented 7 years ago

You welcome! Yes, I will be able to test the fix on my device. For now, when the property is deactivated I'm able to slide horizontally to change PivotItem (today, week, month).

aalok05 commented 7 years ago

I'm disabling IsPullToRefreshWithMouseEnabled property on mobile devices, so users will be able to slide horizontally .