search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 34 forks source link

Hamburger menu custom acrylic brush doesn't switch source when in expanded UI #35

Closed Sergio0694 closed 7 years ago

Sergio0694 commented 7 years ago

As seen in the screenshot, the hamburger menu effect should switch from the in-app blur to the background blur when the app UI is in the extended mode, as otherwise there's no in-app content to blur and the whole effect becomes useless.

image

aalok05 commented 7 years ago

Hey @Sergio0694 , I'm having an issue with this. On state change of Window, when I change the background of Hamburger menu to acrylic brush, there is an issue wherein the screen flickers and the host blur stops working after that. I do dispose the existing in app blur effect.

Sergio0694 commented 7 years ago

@aalok05 Wait, why are you talking about disposing the effect manually? I thought you were using the CustomAcrylicBrush class. With that, you could just bind the Mode property to be able to switch between in-app and background blur when needed.

aalok05 commented 7 years ago

I check the build, and for unsupported builds I use normal blur effect which needs to be disposed.

aalok05 commented 7 years ago

Anyway the switching causes a flicker in my laptop screen that lasts a few seconds...maybe I am doing something wrong.

Sergio0694 commented 7 years ago

Mh, I'm not sure, I'll take a look at the code when I have some time, could you link the exact line/file where you switching the effects?

aalok05 commented 7 years ago

Here it is 31c0f3a5e6abe5b06b6f750c4887d3f0725aa2dc , I've created a separate branch for this