search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

Add indicator for notifications on the bell #41

Closed kumarharsh closed 7 years ago

kumarharsh commented 7 years ago

Right now, there is no indication that there are unread notifications.

Sergio0694 commented 7 years ago

@aalok05 In order to implement this we'd have to make an additional API request every time the page is loaded again to check if there are new notifications. Since this might impact on the data usage/battery, it might be a good idea to turn it on by default on PCs, and add a setting for it on mobile phones.

aalok05 commented 7 years ago

This is a good one @kumarharsh . I was thinking about this. @Sergio0694 we might have to make a setting, for now we'll just go ahead and make a call every time a page is loaded.

aalok05 commented 7 years ago

PR is in progress https://github.com/aalok05/CodeHub/tree/feature_unread_notif_indicator

aalok05 commented 7 years ago

57 adds this feature.