search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

The user avatar shape on the "contributors" pane is different. #42

Closed kumarharsh closed 7 years ago

kumarharsh commented 7 years ago

Its rounded rectangle instead of a circle.

Sergio0694 commented 7 years ago

@aalok05 I guess this is a design choice and not an oversight, but take a look into it just in case

aalok05 commented 7 years ago

This is a design choice. User List items throughout the app have rounded rectangles. If I get more feedback in favor of circles, I'll go for circles when UWP community Toolkit comes out with RoundImageEx control in v 1.5

kumarharsh commented 7 years ago

OK. I see. Although all other places have circles, so I assumed it was an oversight. Plus, many corporate logos get cut-off when circle is used for avatar.

aalok05 commented 7 years ago

@kumarharsh that is true, maybe we'll use rounded rectangles for all avatars in the future.