search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

When create a new PR #54

Closed PoLaKoSz closed 7 years ago

PoLaKoSz commented 7 years ago

I recognize I create a lot of PR but only 1-2 commits in it. What is the best practice to avoid the lot of PR per day? Is somewhere an article about it?

aalok05 commented 7 years ago

A PR should be concerned with only 1 feature/fix. Create a separate branch for a feature that you are working on, name the branch 'feature_featureName', and when that feature is completely implemented in your branch, create a PR for it.

PoLaKoSz commented 7 years ago

Thank you so much for your fast response. I want to be 100% sure about this so I want to ask is that means my #52 PR is not well executed because I didn't separate the 2 fixes?

aalok05 commented 7 years ago

Several fixes can be merged in a single PR, that's fine. But not several features.

PoLaKoSz commented 7 years ago

Thank you. I will pay attention for this.