search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

Watch button show the correct number #56

Closed PoLaKoSz closed 7 years ago

PoLaKoSz commented 7 years ago

Fixed #55

PoLaKoSz commented 7 years ago

Please not merge yet if looks good for you, because I want to dive deeper why something broken in OctoKit.NET.

PoLaKoSz commented 7 years ago

Created an issue on OctoKit hope I get an answer. :)

PoLaKoSz commented 7 years ago

It's really sad, I think the original GitHub API is the reason why the UI shows the wrong number (OctoKit.NET) If you reviewed my code and fine I won't add more code to it so you can merge it.

aalok05 commented 7 years ago

Made some changes here 3327893c5492c88ae0b60a9f928c0c0bbc237095 . We'll get a new repository object only when SubscribersCount is 0. This way we have to call the API method fewer times.

PoLaKoSz commented 7 years ago

Thanks for the feedback.