search

aalok05 / CodeHub

A UWP GitHub Client
MIT License
177 stars 35 forks source link

[ Feature ] Cleaner menu names #81

Closed PoLaKoSz closed 7 years ago

PoLaKoSz commented 7 years ago

Hy!

After I started to translate the UI I found out that the Page Titles are repeated in a lot of files and cannot be translated so I thought this would be helpful: (Please don't merge it if You think this PR is helpful, thanks.)

aalok05 commented 7 years ago

Hey @PoLaKoSz This is great!

Sergio0694 commented 7 years ago

@PoLaKoSz could you please avoid creating 1000 different commits with a single line change in each one of them? If you're just working on some translation strings, just fix all of them and push a single "Updated translation string references"-kind-of commit.

Also, try to use a meaningful name for your commits, for example, "FeedView support" - what does that even mean? If I saw a commit with that name I'd think it contains some additional feature regarding the user feed, not just a single translation string added.

Just trying to give you some feedback here, thank you for your help!

PoLaKoSz commented 7 years ago

@Sergio0694 Thanks for Your feedback I really appreciate it. In the feature I will try to avoid them.

PoLaKoSz commented 7 years ago

@aalok05 You can merge if You want.

aalok05 commented 7 years ago

Great!

PoLaKoSz commented 7 years ago

Wrong branch I'll create a new PR ... or can You merge the aalok05:feature/cleaner-menuNames branch to dev, please?