No colors on diff viewer

aalok05 / CodeHub

A UWP GitHub Client

MIT License

177 stars 35 forks source link

No colors on diff viewer #93

Open sylveon opened 6 years ago

sylveon commented 6 years ago

Sergio0694 commented 6 years ago

@aalok05 Since that's basically a chunk of source code anyways, can't you just use the same API we're already using to get the syntax highlight HTML to display when opening a code file?

aalok05 commented 6 years ago

That's a good idea, however some logic has to be written to color the lines starting with + or -

sylveon commented 6 years ago

Isn't it just possible to use the diff syntax highlighting scheme? Eg:

@@ -52,17 +52,6 @@ struct WINCOMPATTRDATA
// Unchanged code
- // Deleted line
+ // Added line

aalok05 commented 6 years ago

@sylveon This scheme is not yet supported in MarkdownTextblock of UWP community toolkit, which is what we are using. We'll have to create a custom control for this.