1) work on a branch, and when you feel you are finished, make a pull request and have one other team member review it (perhaps not necessary for minor changes/fixes?)
2) run tests before making pull request
3) test should be reviewed too
4) no tabs - all indentation should be 4 spaces
5) when changing/fixing someone else's code, try to maintain their 'style'
6) communicate early if you cannot fulfil a commitment so someone else can schedule help
add to wiki; initial ideas :
1) work on a branch, and when you feel you are finished, make a pull request and have one other team member review it (perhaps not necessary for minor changes/fixes?) 2) run tests before making pull request 3) test should be reviewed too 4) no tabs - all indentation should be 4 spaces 5) when changing/fixing someone else's code, try to maintain their 'style' 6) communicate early if you cannot fulfil a commitment so someone else can schedule help