search

aamay001 / react-resume

Resume Builder in React
https://resumejs.netlify.app/
107 stars 52 forks source link

Changed migratedresume-data.js #105

Closed harshilparmar closed 3 years ago

harshilparmar commented 4 years ago

@aamay001 changed code as per you said in #104 for #72

aamay001 commented 4 years ago

@harshilparmar There is a failing test. Can you please update the test?. See Failing Test

harshilparmar commented 4 years ago

@aamay001 Can you tell me where I am going wrong!! I have also changed cypress/integration/components/Tools/CodeEditor.spec.js. cypressfailed

aamay001 commented 4 years ago

@aamay001 Can you tell me where I am going wrong!! I have also changed cypress/integration/components/Tools/CodeEditor.spec.js. cypressfailed

This is most likely because the test command is formatted for a unix based terminal. Try entering the command directly like this:

npx start-server-and-test "npm start" 3000 "cypress run --headed"

harshilparmar commented 4 years ago

@aamay001 There are two errors.Can please guide. cypressfailed

aamay001 commented 4 years ago

@aamay001 There are two errors.Can please guide. cypressfailed

@harshilparmar Please send me an email so I can provide secrets that are required. Thanks. (My email is on my profile.)

aamay001 commented 4 years ago

@harshilparmar there is an issue with the CI pipeline that is preventing the tests from running successfully. I've contacted MS to get support on this and I will merge in your changes once the issue has been resolved and all tests pass successfully. In the meantime, I have added the label hacktoberfest-accepted to your PR. Thanks for your patience with this.

harshilparmar commented 4 years ago

@aamay001 It's my pleasure brother. looking forward to do more contribution.😃