search

aamay001 / react-resume

Resume Builder in React
https://resumejs.netlify.app/
107 stars 52 forks source link

DownloadButton: Add Cypress Test #77

Closed aamay001 closed 4 years ago

aamay001 commented 4 years ago

https://github.com/aamay001/react-resume/blob/4bfa50523655d76fb7c373f829fb4bef9e05e436/src/components/Tools/Buttons/DownloadButton.js#L5

Test the behavior using Cypress.

Acceptance Criteria

  1. Submit PR to the development branch
  2. Create folder structure to match src tree under cypress\integration
jespicas commented 4 years ago

Hi, I see some PR created to add some Cypress tests, but I don't see a task to execute a Cypress Tests. How you expect execute all test with Cypress in this project ??

aamay001 commented 4 years ago

Hi @jespicas, please make sure you are working from the development branch. There are two scripts in the package.json file to run the Cypress tests.

aamay001 commented 4 years ago

@jespicas I assigned you this issue but you actually did not ask for it. Do you want to work on this? If not I will remove the assignment.

jespicas commented 4 years ago

I can try to do

jespicas commented 4 years ago

This PR contains the test https://github.com/aamay001/react-resume/pull/102

aamay001 commented 4 years ago

Changes requested. Please see PR #102

aamay001 commented 4 years ago

Thanks for your contributions!