search

aamay001 / react-resume

Resume Builder in React
https://resumejs.netlify.app/
107 stars 52 forks source link

MoreVisibilityModal: Add Cypress test #87

Closed aamay001 closed 4 years ago

aamay001 commented 4 years ago

https://github.com/aamay001/react-resume/blob/4bfa50523655d76fb7c373f829fb4bef9e05e436/src/components/Tools/MoreVisibilityModal.js#L31

Test the behavior using Cypress.

Acceptance Criteria

  1. Submit PR to the development branch
  2. Create folder structure to match src tree under cypress\integration if missing
harshilparmar commented 4 years ago

@aamay001 Can I try this? You have to do e2e test right? Only for MoreVisibilityModal ??

aamay001 commented 4 years ago

Yes, you can test for DOM change behavior and data changes in the resume data. This will toggle the isVisible prop for the items that support it.

harshilparmar commented 4 years ago

@aamay001 ok got it !! I will let you know 👍

harshilparmar commented 4 years ago

@aamay001 hello, is this already done in

https://github.com/aamay001/react-resume/pull/90 ??

aamay001 commented 4 years ago

Yes, it is @harshilparmar. Sorry about that. Closing this issue now.

harshilparmar commented 4 years ago

Yes, it is @harshilparmar. Sorry about that. Closing this issue now.

Any other issue that I can solve?

aamay001 commented 4 years ago

@harshilparmar please see #72