I recently implemented the draft-ietf-ntp-roughtime-08 and found no major issues, but there are a number of things in the draft that could use clarification:
[x] Section 5.1.4: Replace reference to PAD tag with ZZZZ
[x] Clarify the semantics of ZZZZ. This replaces the PAD tag from Google-Roughtime and the tag name ensures it is always the last tag in a message. (Say why this is useful for implementations.)
[x] Section 6: Clarify that the units for the "Message length" is bytes. I initially assumed it was number of uint32s, but you clarified on-list that you intended bytres. (I'm fine either way.)
[ ] (Possibly breaking change) Clarify whether the VER tag allows repeated version numbers. I think it should be safe to allow, but worth clarifying.
[x] Clarify the order of values in the PATH tag (root to leaves or leaves to root?)
[ ] Merkel --> Merkle
[ ] Section 6.3: Clarify that "H" is truncated SHA-512
I recently implemented the draft-ietf-ntp-roughtime-08 and found no major issues, but there are a number of things in the draft that could use clarification:
uint32
s, but you clarified on-list that you intended bytres. (I'm fine either way.)VER
tag allows repeated version numbers. I think it should be safe to allow, but worth clarifying.