search

aanckar / react-pdf-tailwind

Use Tailwind CSS to style PDFs created with react-pdf
315 stars 11 forks source link

Remove `dist` from source control #13

Closed chrissantamaria closed 1 year ago

chrissantamaria commented 1 year ago

Tiny PR - just removes the built dist directory from source control, since imo it's not particularly meaningful and can make commits a bit difficult to parse. Shouldn't affect anything on the npm distribution side.

justin-hackin commented 1 year ago

FYI, the examples reference relative paths to dist and thus will break with this PR

chrissantamaria commented 1 year ago

FYI, the examples reference relative paths to dist and thus will break with this PR

Ah, interesting. I think it would just require building the main package locally before running examples, right?

If that manual build step feels cumbersome, we could also migrate to something like pnpm workspaces to more easily manage the entire build process. Might also make the examples a bit simpler to parse rather than importing the package from a relative path.

aanckar commented 1 year ago

I recently published a new release where I basically updated/simplified the entire build process (using tsup instead of rollup, also removed superfluous files from GitHub and npm, respectively). Improvements around building/tooling (CI, changesets etc) could still be made for sure, but considering the current scope of this library I think this is fine for now.

chrissantamaria commented 1 year ago

Sounds good! If you're ever interested in the workspace approach I'd be happy to take a stab at that.