search

aandrew-me / ytDownloader

A modern GUI App for downloading Videos and Audios from hundreds of sites
https://ytdn.netlify.app/
GNU General Public License v3.0
949 stars 87 forks source link

[BUG] Downloading thumbnails of playlists doesn't work #162

Closed Tod902 closed 1 year ago

Tod902 commented 1 year ago

Bug Description Fails to download thumbnails. Also the displayed thumbnail number is always 0. This happens regardless of what playlist I try to download the thumbnails of. Furthermore the "Select Download Location" button, when in the audio tab for a playlist download, doesn't seem to work.

To Reproduce Steps to reproduce the behavior:

  1. Past in a playlist link and then go to the audio tab
  2. Now click download thumbnails (Start and End aren't altered)

Screenshots image image

Error Code Error: Error code: 1 Stderr: ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location ERROR: Preprocessing: ffmpeg not found. Please install or provide the path using --ffmpeg-location

Info (please complete the following information):

aandrew-me commented 1 year ago

Yeah thanks for reporting.

  1. Looks like I forgot to increase count for thumbnails, I have fixed it.
  2. I didn't know it required ffmpeg. I fixed it too. I need to test it on Windows.

So it should be fine in next update

Tod902 commented 1 year ago

Good to hear. Not that it matters now, but I also tried doing it in version 3.11.0, with the same result, except it did count the thumbnail numbers correctly.
Anyway thanks for making this Application and have a lovely day!

aandrew-me commented 1 year ago

Good to hear. Not that it matters now, but I also tried doing it in version 3.11.0, with the same result, except it did count the thumbnail numbers correctly. Anyway thanks for making this Application and have a lovely day!

Great, also if you want you can help with testing. Update needs time to come out but you can have early version if you need. In that case you can message me on telegram