search

aandrew-me / ytDownloader

A modern GUI App for downloading Videos and Audios from hundreds of sites
https://ytdn.netlify.app/
GNU General Public License v3.0
924 stars 85 forks source link

A file isn't downloaded when there's a file with the same name #190

Closed motionnblur closed 6 months ago

motionnblur commented 6 months ago

Bug Description Title

To Reproduce Steps to reproduce the behavior:

  1. Download a file with name XYZ
  2. Download a different file with name XYZ

Info (please complete the following information):

bug1 bug2

video links i was trying to download if it may help you https://www.youtube.com/watch?v=4zeUOUo09Hs&t=7s https://www.youtube.com/watch?v=ZVb_yKMivqo&t=8s

Hi, thanks all of your efforts very appreciated, i use your app all day and really like it. I encountered that small problem, don't know if it's caused by only my system and wanted to create a bug report, because i don't know electron apps so couldn't figure out where the problem came out by looking into code.

aandrew-me commented 6 months ago

Hello! Glad that the program could help you

Well its not a bug. Its like this because if for some reason you couldn't complete the download, it will resume from there. If you need you can easily change the file name before downloading.

motionnblur commented 6 months ago

Hi thanks for the answer, i made a mp3 list and started to download them, luckly there was 2 different file but with same name in my list, the one was downloaded and processed seamlessly then the other one downloaded but it got stuck at processing stage and i thought that's because they had same file names. I'll try to re-produce the error and will edit my post with a screenshot as soon as possible. Thanks.

motionnblur commented 6 months ago

i just uploaded images about the error message

aandrew-me commented 6 months ago

Thanks for the provided information, I will check

aandrew-me commented 6 months ago

I will add the id to the name so that there aren't conflicts

motionnblur commented 6 months ago

Thanks just tried the app again after these latest changes and downloading the two files i mentioned earlier, the problem has been fixed. I think we can close the issue request, what u you think ?. Thanks. aa

aandrew-me commented 6 months ago

Well I didn't even push an update to releases, but I assume you are building it yourself?

aandrew-me commented 6 months ago

Yes in git

motionnblur commented 6 months ago

I mean, I just wanted to say that with your latest update the problem is no longer exists be it on git.

aandrew-me commented 6 months ago

Yes well let me close it then