search

aandrew-me / ytDownloader

A modern GUI App for downloading Videos and Audios from hundreds of sites
https://ytdn.netlify.app/
GNU General Public License v3.0
924 stars 85 forks source link

added some features to linux.sh file #191

Closed motionnblur closed 6 months ago

motionnblur commented 6 months ago

Hi, i realized that ffmpeg link in linux.sh is outdated, i think they deleted it. https://github.com/yt-dlp/FFmpeg-Builds/releases/latest/download/ffmpeg-n5.1-latest-linux64-gpl-5.1.tar.xz

i changed the link to this, to the latest ffmpeg: https://github.com/yt-dlp/FFmpeg-Builds/releases/download/autobuild-2024-02-22-14-09/ffmpeg-N-113784-g4ea2b271eb-linux64-gpl.tar.xz

So that's why i couldn't build the app with npm run linux command. Besides the new ffmpeg link, i think that some sort of basic build system may required like downloading ffmpeg, rpm and wget if these packages aren't already installed on the local system. So i wanted to modify your linux.sh script and tested it on EndeavourOs(Arch) and Debian(Xfce) and works great. But for rpm based systems like Fedora i couldn't run it, i was getting a some sort of rpm error which was already installed on rpm based systems if you will. Also added libxcrypt-compat installing feature, because distributions other than ubuntu based ones requires that.

Have a good day !

motionnblur commented 6 months ago

I'm curious about your opinions

aandrew-me commented 6 months ago

Those files are there because once I used to build locally, however then I switched to GitHub ci. So I forgot about them

aandrew-me commented 6 months ago

The script is putting so much effort on downloading wget which I think is unnecessary. It can be changed to curl instead. I use a custom ffmpeg downloaded from one of my repos. And you dont have to build for all those formats. You just need to download ffmpeg however you like, put in in that directory and name it ffmpeg and then run

npx electron-builder -l appimage

That way it will just build the appimage. You can also choose other formats like pacman, zip...

I will update the readme

aandrew-me commented 6 months ago

I updated the scripts and readme

motionnblur commented 6 months ago

Okay so from my understanding the problem is solved, thanks for all your efforts couldn't think the same way that you do think since I'm french on the code base. So, since the problem is solved, I can close my PR :)