aandrew-me / ytDownloader

A modern GUI App for downloading Videos and Audios from hundreds of sites
https://ytdn.netlify.app/
GNU General Public License v3.0
1.08k stars 96 forks source link

[BUG] MacOS GUI disappears when moving app from installed location #234

Closed FredsMedia closed 2 months ago

FredsMedia commented 2 months ago

Bug Description

To Reproduce Steps to reproduce the behavior:

  1. Open application in one location on fresh install (e.g. Desktop)
  2. Close app and move to a different location (e.g. Applications Folder)
  3. Open app
  4. No main menu GUI

Screenshots

Screenshot 2024-08-22 at 7 35 36 pm

Info (please complete the following information):

FredsMedia commented 2 months ago

If i copy it back to the desktop there is still no GUI. I have also tried deleting the application support folder and relaunching but that hasn't helped. Is there some way to make it do the initial setup again?

aandrew-me commented 2 months ago

Which file are you downloading, . dmg or . app?

FredsMedia commented 2 months ago

i got the x64 .dmg

aandrew-me commented 2 months ago

I tested on an intel Mac just now, it loads but it just takes a lot of time. It took 35 seconds for that button to appear. I will look into why its happening

FredsMedia commented 2 months ago

huh, so it does. It doesnt seem to use heaps of resources...

aandrew-me commented 2 months ago

Apparently there some issue with the yt-dlp executable. That's what's causing it.

Its executing the command

/Users/$USER/.ytDownloader/ytdlp --version

Which is taking a very long time

FredsMedia commented 2 months ago

yep. I ran that myself and it about matches the startup time.

aandrew-me commented 2 months ago

Yeah seems to be some issue with the newer versions of yt-dlp, I tried with an older version and it ran fast

aandrew-me commented 2 months ago

I will see what I can do

aandrew-me commented 2 months ago

I have opened an issue there, you may add a comment too https://github.com/yt-dlp/yt-dlp/issues/10826

FredsMedia commented 2 months ago

Welp, it looks like they aren't doing/can't do anything about it. Would there be a way to skip the version check?

aandrew-me commented 2 months ago

Well the issue isnt just the version check, any command executed with yt-dlp will be slow, getting video info, downloading video...

aandrew-me commented 2 months ago

Thumbs down to Macos, I guess I will have to take a different approach with Mac. Can you please try executing-

python3 --version
FredsMedia commented 2 months ago

Thumbs down to Macos, I guess I will have to take a different approach with Mac. Can you please try executing-

python3 --version

Sure.

Python 3.11.2

aandrew-me commented 2 months ago

Great thanks! Did you install python by yourself or was it already there?

FredsMedia commented 2 months ago

I believe that version was preinstalled

aandrew-me commented 2 months ago

Great, thanks

aandrew-me commented 2 months ago

Then this issue should be fixed in next update

FredsMedia commented 2 months ago

What are ya planning to do?

aandrew-me commented 2 months ago

yt-dlp also provides a script which requires python to be installed in the system. You can try downloading it and checking its version

https://github.com/yt-dlp/yt-dlp/releases/download/2024.08.06/yt-dlp

aandrew-me commented 2 months ago

I will switch to that for macos, the drawback will be that embedding of thumbnails will likely not be possible

FredsMedia commented 2 months ago

I know macOS provides a version of python, I’m not sure what version it installs as I have installed a newer version of python myself. It should still work though.

aandrew-me commented 2 months ago

As far as I know, it requires python 3.8 or greater. I will have to add that to info

FredsMedia commented 2 months ago

Lemme check the default version real quick

FredsMedia commented 2 months ago
Screenshot 2024-08-25 at 8 44 38 pm

It seems to be python 3.9.6, so it should work.

aandrew-me commented 2 months ago

Okay great

FredsMedia commented 2 months ago

I mean if it doesn’t work, you’ll know pretty quick 😅

aandrew-me commented 2 months ago

Let me know how it goes in the latest update

FredsMedia commented 2 months ago

https://github.com/user-attachments/assets/a898e07c-5b1d-4da6-86bf-cbf07245612f

loads up waaaay faster now, i'll download a video later to test that too but so far it looks good!

FredsMedia commented 2 months ago

Yep, it seems like it's working fine (but significantly faster ofc)

aandrew-me commented 2 months ago

Awesome!