search

aandrewww / pino-sentry

🚥 Load pino logs into Sentry
MIT License
61 stars 29 forks source link

Make compatible with v8 of `@sentry/node` #68

Open mydea opened 5 months ago

mydea commented 5 months ago

This currently depends on v6 or v7 of the Sentry SDK, meaning it is not compatible with v8 as of now.

Lms24 commented 5 months ago

Adding to this, have you tried making a pino integration for Sentry rather than initializing the SDK a second time? Users will highly likely already have a Sentry setup, so plugging into this setup rather than initializing the SDK should work better.

We generally recommend this pattern for Sentry add on library creators. The docs still need an update to v8 but we're working on this at the moment.

sergio-milu commented 5 months ago

Having this same issue right now with Sentry v8 and pino-sentry

glensc commented 5 months ago

@Lms24 there are two pull requests implementing it, but nobody to test or respond in them

and two related open issues:

glensc commented 5 months ago

what are the changes? send a pr?

glensc commented 1 week ago

also, the global install mode would get broken if using peer dependencies:

suggestions?