Closed aantron closed 1 year ago
There is still an issue remaining:
Thanks for the heads up! I've fixed some incompatibilities in 9439ba7, but I'm currently left with: λ make -C test/js full-test [...] > node ./lib/js/hello.js internal/modules/cjs/loader.js:818 throw err; ^ Error: Cannot find module '/home/antron/code/bisect/bisect_ppx/test/js/lib/js/hello.js' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15) at Function.Module._load (internal/modules/cjs/loader.js:667:27) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) at internal/main/run_main_module.js:17:47 { code: 'MODULE_NOT_FOUND', requireStack: [] } This is the former location of the output, hello.js, with ReScript <= 10. As far as I can tell, there is no output file at all now: λ cd test/js && find lib 2 lib lib/bs lib/bs/.bsdeps lib/bs/.bsbuild lib/bs/.compiler.log lib/bs/build.ninja lib/bs/.ninja_log lib/bs/install.ninja lib/bs/.sourcedirs.json lib/js Could you suggest what changed in ReScript 11? I wasn't able to spot a relevant change in the changelogs for the ReScript 11 pre-release versions.
Thanks for the heads up! I've fixed some incompatibilities in 9439ba7, but I'm currently left with:
λ make -C test/js full-test [...] > node ./lib/js/hello.js internal/modules/cjs/loader.js:818 throw err; ^ Error: Cannot find module '/home/antron/code/bisect/bisect_ppx/test/js/lib/js/hello.js' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15) at Function.Module._load (internal/modules/cjs/loader.js:667:27) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) at internal/main/run_main_module.js:17:47 { code: 'MODULE_NOT_FOUND', requireStack: [] }
This is the former location of the output, hello.js, with ReScript <= 10. As far as I can tell, there is no output file at all now:
hello.js
λ cd test/js && find lib 2 lib lib/bs lib/bs/.bsdeps lib/bs/.bsbuild lib/bs/.compiler.log lib/bs/build.ninja lib/bs/.ninja_log lib/bs/install.ninja lib/bs/.sourcedirs.json lib/js
Could you suggest what changed in ReScript 11? I wasn't able to spot a relevant change in the changelogs for the ReScript 11 pre-release versions.
This appears to be a silent compilation error.
cc @cristianoc
There is still an issue remaining:
This appears to be a silent compilation error.
cc @cristianoc