aantron / dream

Tidy, feature-complete Web framework
https://aantron.github.io/dream/
MIT License
1.61k stars 129 forks source link

Restore Mirage build in CI after upstream fixes #344

Open aantron opened 2 months ago

aantron commented 2 months ago

During #337 we discovered that many of the dependencies of dream-mirage are still being updated to mirage-crypto 1.0.0. This is fine, but it eventually prevented us from getting the Mirage build working again within a reasonable amount of time. This issue is a reminder to try it again once https://github.com/robur-coop/ocaml-letsencrypt/pull/34 is released, and any other dependencies that are still waiting that we may discover subsequently.

hannesm commented 2 months ago

You'll need to wait for a release of the mirage tool -- with https://github.com/mirage/mirage/pull/1559 being merged. I will ping you here once I think this should be a smooth sail. :)

aantron commented 2 months ago

Great, thank you!

aantron commented 1 month ago

@hannesm I see the tool has been released with that PR. Is this ready for attention again?

hannesm commented 1 month ago

Oh yes indeed. Sorry I forgot to notify you. With the latest mirage you should be able to get dream-mirage and its examples working :)

If you need help with that, let me know and I'll try to find some time to look into that.