search

aantron / lambdasoup

Functional HTML scraping and rewriting with CSS in OCaml
https://aantron.github.io/lambdasoup
MIT License
384 stars 31 forks source link

Add support for selector list #16

Closed Lyokovic closed 3 years ago

Lyokovic commented 6 years ago

Hi,

Here is the implementation of #15, thanks for your advice! I was not sure if I should split the select function, it did not looked weird to me to leave it like that.

I quickly tested it with a simple selector and with a selector list and it seems to work as (I) expected.

Lyokovic commented 6 years ago

Hah, maybe running the tests could help... Back to work :p

aantron commented 6 years ago

Yes, thank you :)

I would recommend also adding new tests for the new functionality.

aantron commented 6 years ago

@Lyokovic, it turns out some of the test failures were caused by an upstream change. I've adjusted to that in master (see d51e1c300484d0cb0ceab4d5859ecea056657b61). After rebasing on master, there are still some failures, that look related to the new code, but the test results are much less noisy.

Lyokovic commented 6 years ago

I just pushed a fix of a quite obvious mistake. But there is still one more failure with my branch, I do not get what is wrong :/

I'll continue investigating and try to add some tests later.

aantron commented 6 years ago

No problem, take your time. And let me know if you would like any form of assistance :)

aantron commented 3 years ago

Closing this PR as stale.