Make forced HTML5 doctype optional.

aantron / lambdasoup

Functional HTML scraping and rewriting with CSS in OCaml

https://aantron.github.io/lambdasoup

MIT License

383 stars 31 forks source link

Make forced HTML5 doctype optional. #33

Closed dmbaturin closed 4 years ago

dmbaturin commented 4 years ago

Backwards-compatible version of the improvement proposed in #32

dmbaturin commented 4 years ago

I'm ready to discuss the design and make changes if needed. We'll also need to add tests for the path without forced doctype I guess—for now I just made the old tests pass.

I did get mad about the stealthy incompatible behaviour change not reflected in the version number, but it doesn't mean I'm no longer willing to collaborate. Could happen to me as well (did, in fact, more than one time).

dmbaturin commented 4 years ago

Not sure where a 0.3% coverage is still missing. If you agree with the design, I'll take another look at getting it back to 100%.

aantron commented 4 years ago

Superseded by d066d16487f02525499875a83881e4fe2342566f.