Use misnested body attributes

aantron / lambdasoup

Functional HTML scraping and rewriting with CSS in OCaml

https://aantron.github.io/lambdasoup

MIT License

384 stars 31 forks source link

Use misnested body attributes #35

Closed apeschar closed 4 years ago

apeschar commented 4 years ago

This relates to https://github.com/aantron/markup.ml/issues/54: attributes on illegally positioned (misnested) body tags are disappeared. This PR tries to correct that behaviour to follow the spec, where such attributes are moved to the main body tag, if they are not already defined there.

It won't win a beauty contest, but I think it does what is needed.

apeschar commented 4 years ago

Hey @aantron, hope you are well. :) Is there anything I can do to make this more mergeable?

aantron commented 4 years ago

Thanks! Sorry for the delay. I will release this shortly together with Markup.ml and the right version constraints on it.

aantron commented 4 years ago

This is now available in opam as lambdasoup 0.7.2 (and markup 1.0.0). Thanks again!

apeschar commented 4 years ago

Awesome, thanks for the update!