search

aantron / lambdasoup

Functional HTML scraping and rewriting with CSS in OCaml
https://aantron.github.io/lambdasoup
MIT License
380 stars 31 forks source link

Add minimal GitHub Actions CI to build the project and run tests #44

Closed dmbaturin closed 2 years ago

dmbaturin commented 2 years ago

I copied most of it from soupault's CI setup. Hope it helps.

aantron commented 2 years ago

AFAICT this setup is Mac-specific and uses only one version of OCaml, so it wouldn't have caught the issue in https://github.com/ocaml/opam-repository/pull/19789. The way in which this setup is Mac-specific won't allow it to be readily extended to other systems, because it relies on Homebrew. So, I'd prefer to pass on this setup, in favor of something cross-platform that also uses multiple OCaml versions, such as what I have for Luv.

dmbaturin commented 2 years ago

I used macOS build host for soupault to have it double as a way to build macOS binaries, since I don't have any Apple hardware anymore, so I can't build them myself.

It's indeed far from comprehensive since it won't work on anything but macOS, so yeah, it would only be good as a stopgap measure to have some CI rather than no CI at all.

aantron commented 2 years ago

Ok, thanks! I merged it to start with, as you point out, and I'll mutate it into a fuller matrix later. I changed this PR so that it wouldn't close #41. I'd like to leave that issue open as a reminder to myself to indeed get around to putting in a full matrix.