aantron / luv

Cross-platform asynchronous I/O and system calls
https://aantron.github.io/luv
MIT License
275 stars 26 forks source link

Define CAML_NAME_SPACE before including caml headers #139

Closed MisterDA closed 1 year ago

MisterDA commented 1 year ago

This fixes incorrect deprecation warnings when variable names collide with name previously defined by caml headers. It is also a bit cleaner since this won't trigger the inclusion of the <caml/compatibility.h> header. This fixes warnings up to OCaml 4.14, the compatibility mode has been removed in OCaml 5.0.

(cc @emillon, with whom we've also seen this issue)

Fix #136 subsumes part of #137

aantron commented 1 year ago

Many thanks!!