search

aantron / markup.ml

Error-recovering streaming HTML5 and XML parsers
http://aantron.github.io/markup.ml
MIT License
146 stars 16 forks source link

Improve error messages for misnested elements #77

Open aantron opened 10 months ago

aantron commented 10 months ago

From https://github.com/ocsigen/tyxml/issues/322:

There is a popular way to style checkbox based on this HTML code:

  <label class="switch" for="checkbox">
    <input type="checkbox" id="checkbox" />
    <div class="slider"></div>
  </label>

What I did not realise is that this HTML, although popular, does not respect the specification (div should be span here).

TyXML does detect that and correctly rejects the program:

let%html checkbox =
  "<label class='switch' for='checkbox'>"
    "<input type='checkbox' id='checkbox' />"
    "<div class='slider'></div>"
  "</label>"

However, the error message is just wrong: Error: Unmatched start tag 'label', pointing at the beginning of the label element. It took me quite a long time to understand what was happening: it would be nice to have it pointing to the div element instead and state that it can't be within a label element.

I'm using TyXML 4.6.0 with tyxml-ppx.

cc @MBodin