search

aantron / promise

Light and type-safe binding to JS promises
MIT License
341 stars 24 forks source link

Format with refmt? #59

Closed cknitt closed 4 years ago

cknitt commented 4 years ago

Is there a reason why the source is not formatted with refmt?

aantron commented 4 years ago

Yes.

  1. When I last tried refmt (admittedly, ~2 years ago), I found it made the code much less legible to me. Among other things, it butchers the consistency of the .rei file for the many repetitive functions, by formatting them only locally according to the lengths of the tokens in each function signature.
  2. Outside contributors are so rare that I found using a global "blind" format not worth the tradeoff in light of (1).

See also #48.

cknitt commented 4 years ago

Ah, ok. Sorry, didn't see #48. Yes, refmt certainly comes with some trade-offs. Personally, I prefer not having to think about formatting anymore, even if the automatic formatting is less than perfect.