aaowens / PSID.jl

Quickly assemble data from the Panel Study of Income Dynamics (PSID)
MIT License
25 stars 9 forks source link

Handling missing variables from codebook that are present in data and crosswalk files #53

Open maqifrnswa opened 1 week ago

maqifrnswa commented 1 week ago

First off, thank you! This project is so helpful!

I came across a few variables that are missing from PSIDcodebook.xml but are in the data and psid.xls. I know you don't maintain any of those files, but it does cause makePSID to error out. Should there be a fallback in those cases? Maybe if it is present in the .xls, but not in the xml, it still processes everything but leaves the _label column blank? I think that's the only consequence of not having the codebook.

Example variables that are missing in the xml files but are in the xls file:

aaowens commented 1 week ago

It is a good idea to not error and leave the _label blank. I'll look at it in a week or so.