search

aap / librw

A re-implementation of the RenderWare Graphics engine
MIT License
579 stars 95 forks source link

fix cmake build #92

Closed withmorten closed 3 years ago

aap commented 3 years ago

I don't think not building the examples/tools is a good solution. it would be a lot better if we do build the examples but such that it actually works. BUT there should be a way to only build core librw because that's all we need for reGTA

withmorten commented 3 years ago

@madebr do you have any idea how to achieve that? have the tools in the conanfile enabled for the librw repo, but not in the re3 builds?

also we need to probably add -std=c++11 to the build flags on mac (at least) for imgui in the tools (the reason it breaks on re3 currently).

withmorten commented 3 years ago

gah, now the ubuntu build fails with: while calling '_build_cmake', line 270 tools.rename("libpulse.pc", "libpulse-simple.pc") ConanException: rename libpulse.pc to libpulse-simple.pc failed, dst exists.

madebr commented 3 years ago

@withmorten

@madebr do you have any idea how to achieve that? have the tools in the conanfile enabled for the librw repo, but not in the re3 builds?

This can be done in 2 ways:

Personally, I prefer the first approach as it is the most flexible.

also we need to probably add -std=c++11 to the build flags on mac (at least) for imgui in the tools (the reason it breaks on re3 currently).

This should be fixed in https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html

gah, now the ubuntu build fails with: while calling '_build_cmake', line 270 tools.rename("libpulse.pc", "libpulse-simple.pc") ConanException: rename libpulse.pc to libpulse-simple.pc failed, dst exists.

The problem is that sdl2/2.0.12@bincrafters/stable is unmaintained. There is work to create sdl/2.0.16.

For now, we'll have to ignore the sdl failure.

Is the default option value your only want-have? I can open a pr for that.

withmorten commented 3 years ago

what we currently mostly want is the tools to not be built for re3, but here only, so that the re3 build works again. if you can fix that, please open a PR!

fixing the ci here would be nice, but is not the main priority, this PR is just a testing ground for me right now to see how to achieve that.