search

aap / skygfx

Bringing the PS2 graphics of GTA San Andreas to PC
210 stars 18 forks source link

[GTASA] neoWaterDrops artifacts #5

Closed Blackbird88 closed 7 years ago

Blackbird88 commented 7 years ago

Happens when camera is moved a lot. image

aap commented 7 years ago

Haven't been able to reproduce...maybe I haven't moved the camera enough? Can you make a video?

Blackbird88 commented 7 years ago

Took me a while to reproduce. Not sure what causes it https://www.youtube.com/watch?v=r6aMkPe4jCE

aap commented 7 years ago

Looks like some renderstates having to do with transformation are leaking. I'll check it out soon. A PIX frame would probably help with this.

Blackbird88 commented 7 years ago

Here http://www27.zippyshare.com/v/cXg1XVtd/file.html

Blackbird88 commented 7 years ago

@aap @ThirteenAG says you ignored my PIX frame :(

aap commented 7 years ago

Hadn't looked at it at the time and now that I'm working on it again the file has expired.

Blackbird88 commented 7 years ago

pix_rain.zip

aap commented 7 years ago

The first two frames look fine for me, the third one seems to be incomplete.

Blackbird88 commented 7 years ago

I forgot to mention there's also some leak or something cause the game crashes eventually if it rains. Error is useless really, but timing is consistent. It always happens around 14000+ frames by PIX counter. Unhandled exception at 0x65DD086D in TextInputFramework.dll

Blackbird88 commented 7 years ago

So am I only one getting the crash?

Blackbird88 commented 7 years ago

My game is running at 60 FPS so getting to the 14K frames is much faster. idk if that matters.

Blackbird88 commented 7 years ago

Crash only appears in 32150c5

Latest version seems fine so I'm closing this for now.