Closed fakeid30 closed 3 years ago
@fakeid30 I'm not able to reproduce this on my local machine. Also looks to be working in the ci test as well now. Could possibly have been some downtime on the site
@cullzie I tried just now and saw this again, in the 4th page this time
Already enrolled in Java Programming: For Complete Beginners from scratch - 2020 | Udemy
Course language not wanted: German
Already enrolled in Managerial Accounting / Cost Accounting | Udemy
Successfully enrolled in: Partnership Accounting | Udemy
Already enrolled in Advanced Financial Accounting | Udemy
Successfully enrolled in: Linux for Cloud & DevOps Engineers | Udemy
Already enrolled in How to Write a Romance Novel | Udemy
Moving on to the next page of the course list on tutorialbar.com
Please Wait: Getting the course list from tutorialbar.com...
Page: 4 of 608 scraped
Error: 'NoneType' object has no attribute 'find'
Closing browser
I think this page is the problem: https://www.tutorialbar.com/amazon-prime-membership-499-per-year-youth-offer/
Ye I've opened a PR to address this @fakeid30 . As @oblomovx mentioned I also think it is to do with the Amazon link now on the page
@cullzie Now the script is malfunctioning :'(
It is showing that it is processing the change but in reality it is just clicking the amazon ad
I wonder if we can install adblocker in our browser with selenium first then proceed normally .
I don't think this is a google ad but a referral link. The only way to remove it would be to check the link domain and if its one of the ones we know is an ad remove it
@cullzie another thing I noticed based on last night's change, that it's not enrolling me to any courses , it's just skipping over a list.
@fakeid30 That would be the cache. If you want to see it go through the whole flow just delete the cache between runs
At the moment it just logs In cache: <COURSE NAME HERE>
This can be improved but its not breaking anything
@cullzie there is some kind of breaking change, because once I subscribed to one course , the script stopped working , and just breezed past the other courses. You can see it in the screenshot I provided.
In the master branch I am seeing this too.
This run has gotten me 0 courses.
@fakeid30 Can you try with a new udemy account?
My guess is you are already enrolled for all the links currently on tutorialbar today I can see you did enroll in one course and the rest are saying already enrolled. If you try with a fresh udemy account you will see more than one enroll in a row
@cullzie just tried with a new account and I just get 1 course from 2 pages of scrapping, I'll email you the new account credential so that you can test as well.
@fakeid30 Ok thanks. Did you delete the cache before running?
@fakeid30 Ok thanks. Did you delete the cache before running?
yup i did
@fakeid30 Looks like an issue with the price taking time to render even though it says its displayed in selenium Can you try add a sleep before the check for the price? Won't get a chance to work on this properly until tomorrow
@fakeid30 Looks like an issue with the price taking time to render even though it says its displayed in selenium Can you try add a sleep before the check for the price? Won't get a chance to work on this properly until tomorrow
I'll try this change locally and update , thank you!
@cullzie this worked . Thanks for investigating this . Appreciate it a lot. I'll wait for a proper PR from you.
@fakeid30 Ok good. I'll try find a better way than sleep as it will be pausing for longer than is needed. If I can get the loading element css I can wait until it has disappeared before reading in the text of the price element but I'll have to see how feasible that is
All these issues should be fixed now
I was doing my daily run and encountered this following error, tried on both develop and master branch. Also on the released downloaded from issued release page.
Further reading is required on my part. Tutorialbar, my account in udemy and my internet are in good condition.
This is happening with both Firefox and Chromium. Arch & Ubuntu Linux with python 3.8.6