search

aapatre / Automatic-Udemy-Course-Enroller-GET-PAID-UDEMY-COURSES-for-FREE

Do you want to LEARN NEW STUFF for FREE? Don't worry, with the power of web-scraping and automation, this script will find the necessary Udemy coupons & enroll you for PAID UDEMY COURSES, ABSOLUTELY FREE!
GNU General Public License v3.0
3.14k stars 545 forks source link

Readme.md update #205

Closed Deejuha closed 3 years ago

Deejuha commented 3 years ago

Hello, at the at the beginning I want to say thank you for your great work for a project!

May I suggest a small readme updates?

  1. Deprecation warnings Choose the appropriate file for your browser (from the list below): currently usage of those script is deprecated. I believe description shall contain only the udemy_enroller.py script usage.

  2. When runs Udemy in a language different than English, the script parameters (like category or course language) shall be written in correlated Udemy language. IMHO it's good point just to leave it somewhere in the instruction.

fakeid30 commented 3 years ago

Hey @Deejuha , good evening. Thank you for your nice suggestions.

  1. The readme has been updated in development branch and will be updated when we release the next version. We are waiting to see if comidoc changes anything again.
  2. Different language is not supported and it will be mentioned, yes. Thanks for pointing it out.
fakeid30 commented 3 years ago

@Deejuha this should be fixed now, please take a look and let us know.

Deejuha commented 3 years ago

I've considered this as close - thanks :)

Deejuha commented 3 years ago

Basically it's working, but the parameters passed in settings.yml should be in origin language.

  categories: [Programowanie,IT i oprogramowanie,Muzyka]
  languages: [Angielski,Polski]
fakeid30 commented 3 years ago

So should we mention "non english inputs are not supported. Consider using them at your own risk"?

Deejuha commented 3 years ago

Well, IMHO prettier and nicer would be Non-English inputs are not supported, but as a workaround try to pass parameters in your udemy language.

Wondering if not so supported, haven't looked into the code but it seems like those group names are inherited from udemy itself.

fakeid30 commented 3 years ago

@cullzie opinion?

fakeid30 commented 3 years ago

@Deejuha if we mention that they can use the text in their own language, there's gonna be some weird issues that we can't tackle sooner or later.

Also yes, they are inherited from udemy itself.

cullzie commented 3 years ago

The values are inherited from udemy so if you are using udemy in Spanish the values in settings.yaml should be in Spainish. Ye it just needs to be clearer in the README.md that the values in settings.yaml should be in the same language as the site you are browsing on

Deejuha commented 3 years ago

@fakeid30 do you agree with that? Shall I reopen / do the CR?

fakeid30 commented 3 years ago

@Deejuha i already changed it. Check it out.

Deejuha commented 3 years ago

right! apologize!

fakeid30 commented 3 years ago

@Deejuha wszystko dobrze, nie ma się czym martwić. nie ma potrzeby przepraszać. Mam nadzieję, że wszystko było w porządku? Jeśli w przyszłości okaże się, że wszystko jest w porządku, podawaj więcej sugestii.