aapatre / Automatic-Udemy-Course-Enroller-GET-PAID-UDEMY-COURSES-for-FREE

Do you want to LEARN NEW STUFF for FREE? Don't worry, with the power of web-scraping and automation, this script will find the necessary Udemy coupons & enroll you for PAID UDEMY COURSES, ABSOLUTELY FREE!
GNU General Public License v3.0
3.14k stars 545 forks source link

[FEATURE REQUEST] Remove old caching logic #259

Closed cullzie closed 3 years ago

cullzie commented 3 years ago

Is your feature request related to a problem? Please describe. We can remove the old way of caching now (caching to file) as we are able to get the courses we are currently enrolled in directly from udemy. This means we can quickly check if the course id we have is one we have already enrolled in

Describe the solution you'd like Update udemy.py to have a list of the course_ids we are currently enrolled in. Then we can simply check if we are already enrolled. On successful enrolment we can add the newly enrolled course_id to this list

Describe alternatives you've considered We could leave in the old cache but it is not necessary and consumes disk space

Additional context Add any other context or screenshots about the feature request here.

fakeid30 commented 3 years ago

Good idea.