Create a toggle in settings.yaml that lets the script stop after pre-selected pages

aapatre / Automatic-Udemy-Course-Enroller-GET-PAID-UDEMY-COURSES-for-FREE

Do you want to LEARN NEW STUFF for FREE? Don't worry, with the power of web-scraping and automation, this script will find the necessary Udemy coupons & enroll you for PAID UDEMY COURSES, ABSOLUTELY FREE!

GNU General Public License v3.0

3.14k stars 545 forks source link

Create a toggle in settings.yaml that lets the script stop after pre-selected pages #33

Closed fakeid30 closed 3 years ago

fakeid30 commented 4 years ago

Implementing this closed PR in a modular way is ideal

latelylk commented 4 years ago

I can take this when I go over some of the other setting additions.

fakeid30 commented 3 years ago

@cullzie what's your thought on this ?

cullzie commented 3 years ago

@fakeid30 instead of putting it into settings I think it would be better adding it as a cli argument. What do you think? So you'd call udemy_enroller_chrome.py --max_pages=5 It would also be possible to move to a one file entry point with this udemy_enroller.py --browser=chrome which would probably be necessary for release on pypi

fakeid30 commented 3 years ago

@cullzie yeah --max-pages = X approach is workable 👍🏽