search

aapooksman / certmitm

A tool for testing for certificate validation vulnerabilities of TLS connections made by a client device or an application.
MIT License
230 stars 19 forks source link

Improved readability (PEP8 linting + fixing dirty hacks) #3

Open Sanduuz opened 10 months ago

qdii commented 5 months ago

@Sanduuz instead of removing the OSException, could you log it as well? it may give more details about the failure.

Sanduuz commented 5 months ago

@Sanduuz instead of removing the OSException, could you log it as well? it may give more details about the failure.

Definitely could and there's A LOT of other improvements as well to be done to actually make the codebase maintainable for future :D

But I'm pretty sure that @aapooksman won't merge this either (because "it works, so why break it" ;D) so it would be probably easier to just update my own fork.