In two places, there is a check if a certain keydown event was triggered by the 191 key code to e.g. focus on the input search bar. Even though I think this is wrong or at least might not work on every machine.
At least on my (Ubuntu) Machine, using Brave Browser typing / doesn't result in the key code 191 but in 55 which is the keyCode for 7.
So instead of checking for the keyCode in the two places mentioned further down, but also in the other places I would suggest to use the event.key property instead.
So I would replace e.keyCode === 191 with e.key === '/'.
I verified with the following snippet, that it works accordingly. Also you can see that I type in / but the keyCode55 is printed to the console.
Also after changing this locally the focus on the search input worked again.
In two places, there is a check if a certain
keydown
event was triggered by the191
key code to e.g. focus on the input search bar. Even though I think this is wrong or at least might not work on every machine.At least on my (Ubuntu) Machine, using Brave Browser typing
/
doesn't result in the key code191
but in55
which is thekeyCode
for7
.So instead of checking for the
keyCode
in the two places mentioned further down, but also in the other places I would suggest to use theevent.key
property instead. So I would replacee.keyCode === 191
withe.key === '/'
.I verified with the following snippet, that it works accordingly. Also you can see that I type in
/
but thekeyCode
55
is printed to the console. Also after changing this locally the focus on the search input worked again.The two places: https://github.com/aaranxu/adidoks/blob/6887e4e27144ac7f9bef6fe4287d8dbb2ceca87f/static/index.js#L8 https://github.com/aaranxu/adidoks/blob/e03e8a5098660b9fcf7ea9ad136024cc98723a1f/static/js/search.js#L8
I don't mind preparing a PR/fix for the
191
case, but can also do so for the other ones.